TW-1309

- TW-1309 memory error, if misconfigured calendar.details.report (thanks to
          Onion).

ChangeLog

@@ -49,6 +49,8 @@
 - TW-1302 CmdShow.cpp:244: bad length in substr ? (thanks to David Binderman).
 - TW-1304 Minor build and install fix for NetBSD (thanks to atomicules).
 - TW-1307 burndown is aliased to burndown.weekly (thanks to darkfeline).
+- TW-1309 memory error, if misconfigured calendar.details.report (thanks to
+          Onion).
 - Removed deprecated 'echo.command' setting, in favor of the 'header' and
   'affected' verbosity tokens.
 - Removed deprecated 'edit.verbose' setting, in favor of the 'edit' verbosity

src/commands/CmdCalendar.cpp

@@ -331,7 +331,11 @@ int CmdCalendar::execute (std::string& output)
     // Table with due date information
     if (context.config.get ("calendar.details") == "full")
     {
+      // Assert that 'report' is a valid report.
       std::string report = context.config.get ("calendar.details.report");
+      if (context.commands.find (report) == context.commands.end ())
+        throw std::string (STRING_ERROR_DETAILS);
+
       std::string report_filter = context.config.get ("report." + report + ".filter");
 
       context.a3.clear ();

src/eng-USA.h

@@ -691,6 +691,7 @@
 #define STRING_INVALID_SORT_COL      "The '{1}' column is not a valid sort field."
 #define STRING_TLS_INIT_FAIL         "Error initializing TLS."
 #define STRING_ERROR_MEMORY          "Problem obtaining memory."
+#define STRING_ERROR_DETAILS         "The setting 'calendar.details.report' must contain a single report name."
 
 // Feedback
 #define STRING_FEEDBACK_NO_TASKS     "No tasks."

src/esp-ESP.h

@@ -704,6 +704,7 @@
 #define STRING_INVALID_SORT_COL      "La columna '{1}' no es un campo de ordenación válido."
 #define STRING_TLS_INIT_FAIL         "Error inicializando TLS."
 #define STRING_ERROR_MEMORY          "Problem obtaining memory."
+#define STRING_ERROR_DETAILS         "The setting 'calendar.details.report' must contain a single report name."
 
 // Feedback
 #define STRING_FEEDBACK_NO_TASKS     "Ninguna tarea."

src/fra-FRA.h

@@ -690,6 +690,7 @@
 #define STRING_INVALID_SORT_COL      "The '{1}' column is not a valid sort field."
 #define STRING_TLS_INIT_FAIL         "Error initializing TLS."
 #define STRING_ERROR_MEMORY          "Problem obtaining memory."
+#define STRING_ERROR_DETAILS         "The setting 'calendar.details.report' must contain a single report name."
 
 // Feedback
 #define STRING_FEEDBACK_NO_TASKS     "No tasks."

src/ita-ITA.h

@@ -691,6 +691,7 @@
 #define STRING_INVALID_SORT_COL      "La colonna '{1}' non è un campo di ordinamento valido."
 #define STRING_TLS_INIT_FAIL         "Error initializing TLS."
 #define STRING_ERROR_MEMORY          "Problem obtaining memory."
+#define STRING_ERROR_DETAILS         "The setting 'calendar.details.report' must contain a single report name."
 
 // Feedback
 #define STRING_FEEDBACK_NO_TASKS     "Nessun task."

src/por-PRT.h

@@ -691,6 +691,7 @@
 #define STRING_INVALID_SORT_COL      "A coluna '{1}' não pode ser ordenada."
 #define STRING_TLS_INIT_FAIL         "Erro a iniciar componente TLS."
 #define STRING_ERROR_MEMORY          "Problem obtaining memory."
+#define STRING_ERROR_DETAILS         "The setting 'calendar.details.report' must contain a single report name."
 
 // Feedback
 #define STRING_FEEDBACK_NO_TASKS     "Nenhuma tarefa."