GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-08-28 13:37:20 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

feedback: Replace taskDiff method by Task inequality operator

Browse source
This commit is contained in:
Tomas Babej 2015-09-05 23:14:15 +02:00 • committed by Paul Beckingham
parent efab724802
commit 4042cbf964
5 changed files with 4 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/commands/CmdDenotate.cpp
View file

@ -124,7 +124,7 @@ int CmdDenotate::execute (std::string& output)
}
}
if (taskDiff (before, task))
if (before != task)
{
std::string question = format (STRING_CMD_DENO_CONFIRM,
task.id,

4
src/commands/CmdImport.cpp
View file

@ -184,10 +184,10 @@ void CmdImport::importSingleTask (json::object* obj)
{
// "modified:" is automatically set to the current time when a task is
// changed. If the imported task has a modification timestamp we need
// to ignore it in taskDiff() in order to check for meaningful
// to ignore it in task comparison in order to check for meaningful
// differences. Setting it to the previous value achieves just that.
task.set ("modified", before.get ("modified"));
if (taskDiff (before, task))
if (before != task)
{
CmdModify modHelper;
modHelper.checkConsistency (before, task);

2
src/commands/CmdModify.cpp
View file

@ -76,7 +76,7 @@ int CmdModify::execute (std::string& output)
Task before (task);
task.modify (Task::modReplace);
if (taskDiff (before, task))
if (before != task)
{
// Abort if change introduces inconsistencies.
checkConsistency(before, task);