GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-06-26 10:54:26 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Bug #932

Browse source 
- Fixed bug #932, which fixed change propagation for recurring tasks (thanks to
  Jennifer Cormier).
- Added unit tests, corrected some.
This commit is contained in:
Paul Beckingham 2012-02-20 17:25:31 -05:00
parent 259f39f2d2
commit 39998d5cc5
7 changed files with 138 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
test/bug.360.t
View file

@ -45,7 +45,7 @@ qx{../src/task rc:bug.rc ls};
# Result: trying to add the project generates an error about removing
# recurrence from a task.
my $output = qx{../src/task rc:bug.rc 1 modify project:bar};
my $output = qx{echo '-- y' | ../src/task rc:bug.rc 1 modify project:bar};
unlike ($output, qr/You cannot remove the recurrence from a recurring task./ms, 'No recurrence removal error');
# Now try to generate the error above via regular means - ie, is it actually

74
test/bug.932.t Executable file
View file

@ -0,0 +1,74 @@
#! /usr/bin/perl
################################################################################
## taskwarrior - a command line task list manager.
##
## Copyright 2006-2012, Paul Beckingham, Federico Hernandez.
##
## Permission is hereby granted, free of charge, to any person obtaining a copy
## of this software and associated documentation files (the "Software"), to deal
## in the Software without restriction, including without limitation the rights
## to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
## copies of the Software, and to permit persons to whom the Software is
## furnished to do so, subject to the following conditions:
##
## The above copyright notice and this permission notice shall be included
## in all copies or substantial portions of the Software.
##
## THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
## OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
## FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
## THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
## LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
## OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
## SOFTWARE.
##
## http://www.opensource.org/licenses/mit-license.php
##
################################################################################
use strict;
use warnings;
use Test::More tests => 11;
# Create the rc file.
if (open my $fh, '>', 'bug.rc')
{
print $fh "data.location=.\n",
"confirmation=off\n";
close $fh;
ok (-r 'bug.rc', 'Created bug.rc');
}
# Bug 932: Modifying recurring task's recurrence period - strange outcome
# - add a recurring task with multiple child tasks
# - modify a child task and test for propagation
# - modify the parent task and test for propagation
qx{../src/task rc:bug.rc add R due:yesterday recur:daily};
my $output = qx{../src/task rc:bug.rc list};
like ($output, qr/2.+R/ms, 'Found child 0');
like ($output, qr/3.+R/ms, 'Found child 1');
like ($output, qr/4.+R/ms, 'Found child 2');
qx{echo '-- y' | ../src/task rc:bug.rc 2 mod project:P};
$output = qx{../src/task rc:bug.rc list};
like ($output, qr/2\s+P.+R/ms, 'Found modified child 0');
like ($output, qr/3\s+P.+R/ms, 'Found modified child 1 (propagated from 0)');
like ($output, qr/4\s+P.+R/ms, 'Found modified child 2 (propagated from 0)');
qx{echo '-- y' | ../src/task rc:bug.rc 1 mod priority:H};
$output = qx{../src/task rc:bug.rc list};
like ($output, qr/2\s+P.+H.+R/ms, 'Found modified child 0 (propagated from parent');
like ($output, qr/3\s+P.+H.+R/ms, 'Found modified child 1 (propagated from parent)');
like ($output, qr/4\s+P.+H.+R/ms, 'Found modified child 2 (propagated from parent)');
# Cleanup.
unlink qw(pending.data completed.data undo.data backlog.data synch.key bug.rc);
ok (! -r 'pending.data' &&
! -r 'completed.data' &&
! -r 'undo.data' &&
! -r 'backlog.data' &&
! -r 'synch.key' &&
! -r 'bug.rc', 'Cleanup');
exit 0;

2
test/dependencies.t
View file

@ -122,7 +122,7 @@ qx{../src/task rc:dep.rc add Six recurring due:tomorrow recur:daily};
# [20]
qx{../src/task rc:dep.rc ls}; # To force handleRecurrence call.
$output = qx{../src/task rc:dep.rc 6 modify dep:5};
$output = qx{echo '-- y' | ../src/task rc:dep.rc 6 modify dep:5};
like ($output, qr/Modified \d+ task/, 'dependencies - recurring task depending on another task');
# [21]