diff --git a/src/Task.cpp b/src/Task.cpp index 64040d1a4..c93810582 100644 --- a/src/Task.cpp +++ b/src/Task.cpp @@ -200,7 +200,7 @@ bool Task::has (const std::string& name) const std::vector Task::all () { std::vector all; - for (auto i : data) + for (const auto& i : data) all.push_back (i.first); return all; @@ -836,7 +836,7 @@ std::string Task::composeF4 () const std::string ff4 = "["; bool first = true; - for (auto it : data) + for (const auto& it : data) { // Orphans have no type, treat as string. std::string type = Task::attributes[it.first]; @@ -931,7 +931,7 @@ std::string Task::composeJSON (bool decorate /*= false*/) const out << "\"tags\":["; int count = 0; - for (auto i : tags) + for (const auto& i : tags) { if (count++) out << ','; @@ -970,7 +970,7 @@ std::string Task::composeJSON (bool decorate /*= false*/) const out << "\"depends\":["; int count = 0; - for (auto i : deps) + for (const auto& i : deps) { if (count++) out << ','; diff --git a/src/feedback.cpp b/src/feedback.cpp index 6cd63e7d2..40a0c9e73 100644 --- a/src/feedback.cpp +++ b/src/feedback.cpp @@ -47,7 +47,7 @@ static void countTasks (const std::vector &, const std::string&, int&, int std::string taskIdentifiers (const std::vector & tasks) { std::vector identifiers; - for (auto task: tasks) + for (const auto& task: tasks) identifiers.push_back (task.identifier (true)); return join (", ", identifiers);