GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-08-19 09:53:08 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

performance: Do not use Pig to extract raw line content

Browse source
This commit is contained in:
Tomas Babej 2021-04-23 22:47:27 -04:00
parent e7487c8a63
commit 312f77f703
1 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/Task.cpp
View file

@ -580,13 +580,14 @@ void Task::parse (const std::string& input)
if (input[0] == '[')
{
Pig pig (input);
std::string line;
if (pig.skip ('[') &&
pig.getUntil (']', line) &&
pig.skip (']') &&
(pig.skip ('\n') || pig.eos ()))
// Not using Pig to parse here (which would be idiomatic), because we
// don't need to differentiate betwen utf-8 and normal characters.
// Pig's scanning the string can be expensive.
auto ending_bracket = input.find_last_of (']');
if (ending_bracket != std::string::npos)
{
std::string line = input.substr(1, ending_bracket);
if (line.length () == 0)
throw std::string ("Empty record in input.");