GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-08-19 09:53:08 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Test: Revert recurrence.t test as per comment

Browse source 
The comment mentions one behaviour but the test was performing another.
It was also failing for a different reason, which is filters with no
matches always exit with non-zero. If the correct behaviour is indeed
expiring all recurring tasks, the test must use runError instead.

Also added a TODO for easier finding.
This commit is contained in:
Renato Alves 2015-07-28 20:01:39 +01:00
parent 3908c29a21
commit 2f15bb8fa5
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
test/recurrence.t
View file

@ -149,15 +149,15 @@ class TestRecurrenceUntil(TestCase):
code, out, err = self.t("list rc.verbose:nothing") code, out, err = self.t("list rc.verbose:nothing")
self.assertEqual(out.count("one"), 3) self.assertEqual(out.count("one"), 3)
# This test currently failing, probably because the 'until' is # TODO This test currently failing, probably because the 'until' is
# propagated to the instances, and expires them also. This is certainly # propagated to the instances, and expires them also. This is certainly
# the way it has been behaving for a while, but is not the original # the way it has been behaving for a while, but is not the original
# intention. Perhaps it is now the de facto functionality, in which # intention. Perhaps it is now the de facto functionality, in which
# change the 3 to a 0. # change the 3 to a 0. The change to 0 also implies use of runError as
# exit code for empty filters is always != 0
self.t.faketime("+24h") self.t.faketime("+24h")
code, out, err = self.t("list rc.verbose:nothing") code, out, err = self.t("list rc.verbose:nothing")
#self.assertEqual(out.count("one"), 3) self.assertEqual(out.count("one"), 3)
self.assertEqual(out.count("one"), 0)
class TestRecurrenceTasks(TestCase): class TestRecurrenceTasks(TestCase):