GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-09-08 15:20:36 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Refactor getDOM to use a pointer for the optional context

Browse source 
It's possible to call getDOM without a contextual task.  Previously,
this was done by referencing a "dummy" task which necessitated a way to
distinguish such dummy tasks.  This switches to using a pointer and
treating the NULL value as meaning there is no context.

Note that this cannot use `std::optional<&Task>`, as optional does not
support reference types.
This commit is contained in:
Dustin J. Mitchell 2021-11-18 02:48:14 +00:00 • committed by Tomas Babej
parent 3af5ceadc1
commit 2812a8c77a
11 changed files with 76 additions and 82 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/commands/CmdGet.cpp
View file

@ -64,9 +64,8 @@ int CmdGet::execute (std::string& output)
{
case Lexer::Type::dom:
{
Task t;
Variant result;
if (getDOM (arg.attribute ("raw"), t, result))
if (getDOM (arg.attribute ("raw"), NULL, result))
results.emplace_back (result);
else
results.emplace_back ("");