From 264e318be518a574b43ff6a6f988605b97ff97ab Mon Sep 17 00:00:00 2001 From: Paul Beckingham Date: Mon, 13 Jul 2015 09:26:47 -0400 Subject: [PATCH] TW-1475: task config expands values with unnecessary spaces - Thanks to Tomas Babej. --- ChangeLog | 2 ++ test/tw-1475.t | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 57 insertions(+) create mode 100755 test/tw-1475.t diff --git a/ChangeLog b/ChangeLog index ebe097770..e7c6e9309 100644 --- a/ChangeLog +++ b/ChangeLog @@ -15,6 +15,8 @@ - TW-1440 "task import" from STDIN (thanks to Renato Alves). - TW-1454 Redundant dependency should not stop modification (thanks to Tomas Babej). +- TW-1475 task config expands values with unnecessary spaces (thanks to Tomas + Babej). - TW-1527 Extra spaces added around slashes (thanks to Renato Alves). - TW-1572 Better urgency inheritance (thanks to Jens Erat). - TW-1600 Filtering "regressions"(?) in task-2.4.3, task-2.4.4 (thanks to Ralph diff --git a/test/tw-1475.t b/test/tw-1475.t new file mode 100755 index 000000000..ff7d74b78 --- /dev/null +++ b/test/tw-1475.t @@ -0,0 +1,55 @@ +#!/usr/bin/env python2.7 +# -*- coding: utf-8 -*- +############################################################################### +# +# Copyright 2006 - 2015, Paul Beckingham, Federico Hernandez. +# +# Permission is hereby granted, free of charge, to any person obtaining a copy +# of this software and associated documentation files (the "Software"), to deal +# in the Software without restriction, including without limitation the rights +# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +# copies of the Software, and to permit persons to whom the Software is +# furnished to do so, subject to the following conditions: +# +# The above copyright notice and this permission notice shall be included +# in all copies or substantial portions of the Software. +# +# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS +# OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL +# THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE +# SOFTWARE. +# +# http://www.opensource.org/licenses/mit-license.php +# +############################################################################### + +import sys +import os +import unittest +# Ensure python finds the local simpletap module +sys.path.append(os.path.dirname(os.path.abspath(__file__))) + +from basetest import Task, TestCase + + +class TestBug1475(TestCase): + def setUp(self): + """Executed before each test in the class""" + self.t = Task() + + def test_config_unmolested(self): + """Verify that a config value is not borked by lex/eval""" + self.t("config name one/two/three") + + code, out, err = self.t("_get rc.name") + self.assertEqual("one/two/three\n", out) + + +if __name__ == "__main__": + from simpletap import TAPTestRunner + unittest.main(testRunner=TAPTestRunner()) + +# vim: ai sts=4 et sw=4