GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-06-26 10:54:26 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

CLI2: Eliminated READCMD/WRITECMD tags

Browse source 
- Now tags command with DNA.
This commit is contained in:
Paul Beckingham 2015-08-22 08:29:23 -04:00
parent 703cfdf2d6
commit 257edc535a
2 changed files with 38 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

44
src/CLI2.cpp
View file

@ -625,10 +625,9 @@ void CLI2::prepareFilter ()
if (cmd && cmd->uses_context ()) if (cmd && cmd->uses_context ())
addContextFilter (); addContextFilter ();
// Classify FILTER and MODIFICATION args, based on CMD and READCMD/WRITECMD. // Classify FILTER, MODIFICATION and MISCELLANEOUS args, based on CMD DNA.
bool changes = false; bool changes = false;
bool foundCommand = false; bool foundCommand = false;
bool readOnly = false;
for (auto& a : _args) for (auto& a : _args)
{ {
@ -638,8 +637,6 @@ void CLI2::prepareFilter ()
if (a.hasTag ("CMD")) if (a.hasTag ("CMD"))
{ {
foundCommand = true; foundCommand = true;
if (a.hasTag ("READCMD"))
readOnly = true;
} }
else if (a.hasTag ("BINARY") || else if (a.hasTag ("BINARY") ||
a.hasTag ("RC") || a.hasTag ("RC") ||
@ -647,12 +644,34 @@ void CLI2::prepareFilter ()
{ {
// NOP. // NOP.
} }
else if (foundCommand && ! readOnly)
// All MODIFICATION args appear after the command.
else if (cmd &&
cmd->accepts_modifications () &&
foundCommand)
{ {
a.tag ("MODIFICATION"); a.tag ("MODIFICATION");
changes = true; changes = true;
} }
else if (!foundCommand || (foundCommand && readOnly))
// All MISCELLANEOUS args appear after the command.
else if (cmd &&
! cmd->accepts_modifications () &&
(foundCommand ||
(! foundCommand &&
! cmd->accepts_filter () &&
cmd->accepts_miscellaneous ())))
{
a.tag ("MISCELLANEOUS");
changes = true;
}
else if (cmd &&
cmd->accepts_filter () &&
(! foundCommand ||
(foundCommand &&
(! cmd->accepts_modifications () ||
! cmd->accepts_miscellaneous ()))))
{ {
a.tag ("FILTER"); a.tag ("FILTER");
changes = true; changes = true;
@ -972,8 +991,15 @@ bool CLI2::findCommand ()
a.attribute ("canonical", canonical); a.attribute ("canonical", canonical);
a.tag ("CMD"); a.tag ("CMD");
bool readOnly = ! exactMatch ("writecmd", canonical); // Apply command DNA as tags.
a.tag (readOnly ? "READCMD" : "WRITECMD"); Command* command = context.commands[canonical];
if (command->read_only ()) a.tag ("READONLY");
if (command->displays_id ()) a.tag ("SHOWSID");
if (command->needs_gc ()) a.tag ("RUNSGC");
if (command->uses_context ()) a.tag ("USESCONTEXT");
if (command->accepts_filter ()) a.tag ("ALLOWSFILTER");
if (command->accepts_modifications ()) a.tag ("ALLOWSMODIFICATIONS");
if (command->accepts_miscellaneous ()) a.tag ("ALLOWSMISC");
if (context.config.getInteger ("debug.parser") >= 3) if (context.config.getInteger ("debug.parser") >= 3)
context.debug (dump ("CLI2::analyze findCommand")); context.debug (dump ("CLI2::analyze findCommand"));
@ -1371,7 +1397,7 @@ void CLI2::findIDs ()
} }
// If no IDs were found, and no filter was specified, look for number/set // If no IDs were found, and no filter was specified, look for number/set
// listed as a MODIFICATION for a WRITECMD. // listed as a MODIFICATION.
std::string command = getCommand (); std::string command = getCommand ();
if (! _id_ranges.size () && if (! _id_ranges.size () &&

2
src/Filter.cpp
View file

@ -288,7 +288,7 @@ void Filter::safety ()
{ {
if (a.hasTag ("CMD")) if (a.hasTag ("CMD"))
{ {
if (a.hasTag ("WRITECMD")) if (! a.hasTag ("READONLY"))
{ {
if (! context.config.getBoolean ("allow.empty.filter")) if (! context.config.getBoolean ("allow.empty.filter"))
throw std::string (STRING_TASK_SAFETY_ALLOW); throw std::string (STRING_TASK_SAFETY_ALLOW);