From 24f56b65a94e86b821c1e30c88834d224e3655e4 Mon Sep 17 00:00:00 2001
From: "Dustin J. Mitchell" <dustin@v.igoro.us>
Date: Wed, 19 Jun 2024 05:17:14 -0400
Subject: [PATCH] Only warn about .data files when showing reports (#3473)

* Only warn about .data files when showing reports

This avoids the warning appearing in shell completion, for example.

* Update src/commands/CmdCustom.cpp

Co-authored-by: ryneeverett <ryneeverett@gmail.com>

---------

Co-authored-by: ryneeverett <ryneeverett@gmail.com>
---
 src/TDB2.cpp               |  8 --------
 src/commands/CmdCustom.cpp | 10 ++++++++++
 2 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/src/TDB2.cpp b/src/TDB2.cpp
index a8c7157dc..e871d4854 100644
--- a/src/TDB2.cpp
+++ b/src/TDB2.cpp
@@ -58,14 +58,6 @@ TDB2::TDB2 ()
 ////////////////////////////////////////////////////////////////////////////////
 void TDB2::open_replica (const std::string& location, bool create_if_missing)
 {
-  File pending_data = File (location + "/pending.data");
-  if (pending_data.exists()) {
-    Color warning = Color (Context::getContext ().config.get ("color.warning"));
-    std::cerr << warning.colorize (
-      format ("Found existing '*.data' files in {1}", location)) << "\n";
-    std::cerr << "  Taskwarrior's storage format changed in 3.0, requiring a manual migration.\n";
-    std::cerr << "  See https://github.com/GothenburgBitFactory/taskwarrior/releases.\n";
-  }
   replica = tc::Replica(location, create_if_missing);
 }
 
diff --git a/src/commands/CmdCustom.cpp b/src/commands/CmdCustom.cpp
index d6e1b7503..bb240bf7d 100644
--- a/src/commands/CmdCustom.cpp
+++ b/src/commands/CmdCustom.cpp
@@ -30,6 +30,7 @@
 #include <sstream>
 #include <map>
 #include <vector>
+#include <iostream>
 #include <algorithm>
 #include <stdlib.h>
 #include <Context.h>
@@ -272,6 +273,15 @@ int CmdCustom::execute (std::string& output)
     }
   }
 
+  std::string location  = (Context::getContext ().data_dir);
+  File pending_data = File (location + "/pending.data");
+  if (pending_data.exists()) {
+    Color warning = Color (Context::getContext ().config.get ("color.warning"));
+    std::cerr << warning.colorize (
+      format ("Found existing '*.data' files in {1}", location)) << "\n";
+    std::cerr << "  Taskwarrior's storage format changed in 3.0, requiring a manual migration.\n";
+    std::cerr << "  See https://github.com/GothenburgBitFactory/taskwarrior/releases.\n";
+  }
 
   feedback_backlog ();
   output = out.str ();