diff --git a/ChangeLog b/ChangeLog index d52c2d202..4e6124a46 100644 --- a/ChangeLog +++ b/ChangeLog @@ -14,6 +14,8 @@ Scott Carter). - Setting 'bulk' to zero is interpreted as infinity, which means there is no amount of changes that is considered dangerous (thanks to Tomas Babej). +- Disable hooks in bash completion script. Hooks were previously able to + abort processing or output interfering data, breaking completion. ------ current release --------------------------- diff --git a/scripts/bash/task.sh b/scripts/bash/task.sh index 506de4a21..e0b232e5e 100644 --- a/scripts/bash/task.sh +++ b/scripts/bash/task.sh @@ -50,7 +50,7 @@ # ################################################################################ #the following variable is substituted for by ../../test/bash_completion.t -taskcommand='task rc.verbose:nothing rc.confirmation:no' +taskcommand='task rc.verbose:nothing rc.confirmation:no rc.hooks:off' _task_get_tags() { $taskcommand _tags diff --git a/test/bash_completion.t b/test/bash_completion.t index 2e0590c72..0ec40dc1d 100755 --- a/test/bash_completion.t +++ b/test/bash_completion.t @@ -55,9 +55,9 @@ if (open my $target, '>', 'task.sh') { my $temp=$_; chomp($_); - if ($_ eq "taskcommand='task rc.verbose:nothing rc.confirmation:no'") + if ($_ eq "taskcommand='task rc.verbose:nothing rc.confirmation:no rc.hooks:off'") { - print $target "taskcommand='../src/task rc.verbose:nothing rc.confirmation:no rc:bug.rc'"; + print $target "taskcommand='../src/task rc.verbose:nothing rc.confirmation:no rc.hooks:off rc:bug.rc'"; } else {