From 11e467fe5ab5900094bab38574ef91f8a3a625fc Mon Sep 17 00:00:00 2001 From: Paul Beckingham Date: Sun, 18 Mar 2018 11:19:56 -0400 Subject: [PATCH] TW #1986: [Nit] Update DEVELOPER.md after migration to Github - Thanks to Kirill Bobyrev --- ChangeLog | 10 ++++++---- DEVELOPER.md | 8 ++++---- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/ChangeLog b/ChangeLog index 3aa0189a6..e34ca31b2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -4,6 +4,10 @@ Thanks to Markus Beppler, Konstantin Vorobyev - TI-91 Timewarrior does not compile on DragonFly Thanks to Michael Neumann +- TW #1 URL formating + Thanks to buhtz +- TW #2 Update to markdown and rename DEVELOPER to DEVELOPER.md + Thanks to Lynoure Braakman - TW-54/#115 Reduce output for timesheet Thanks to Aikido guy - TW-61 Extract only tasks with annotations @@ -85,12 +89,10 @@ Thanks to php-coder - TW #1966 Tests: Don't hardcode errno constants #1966 Thanks to Jakub Wilk -- TW #2 Update to markdown and rename DEVELOPER to DEVELOPER.md - Thanks to Lynoure Braakman -- TW #1 URL formating - Thanks to buhtz - TW #1973 Don't nag when no tasks are READY Thanks to Martin F. Krafft +- TW #1986 [Nit] Update DEVELOPER.md after migration to Github + Thanks to Kirill Bobyrev - Added 'juhannus' as a synonym for 'midsommarafton' Thanks to Lynoure Braakman - Deprecated the 'DUETODAY' virtual tag, which is a synonym for the 'TODAY' diff --git a/DEVELOPER.md b/DEVELOPER.md index 0705d4e1c..bc8ead41e 100644 --- a/DEVELOPER.md +++ b/DEVELOPER.md @@ -125,16 +125,16 @@ All new unit tests should follow the test/template.t standard. # Patches - Patches are encouraged and welcomed. Either attach them to the appropriate - Jira issue, or send them to support@taskwarrior.org. A good patch: + Patches are encouraged and welcomed. Either send a pull request on Github or + email a patch to support@taskwarrior.org. A good patch: * Maintains the MIT license, and does not contain code lifted from other sources. You will have written 100% of the code in the patch, otherwise we cannot maintain the license. * Precisely addresses one issue only. - * Doesn't break unit tests. + * Doesn't break unit tests. This means yes, run the unit tests. * Doesn't introduce dependencies. - * Is accompanied by unit tests, where appropriate. + * Is accompanied by new or updated unit tests, where appropriate. * Is accompanied by documentation changes, where appropriate. * Conforms to the prevailing coding standards - in other words, it should fit in with the existing code.