GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-08-20 04:13:07 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Enhancement

Browse source 
- 'print.empty.columns' now defaults to 'no'.
- Unit tests are updated accordingly.
This commit is contained in:
Scott Kostyshak 2013-02-21 09:53:01 -05:00 • committed by Paul Beckingham
parent 0bcb22f8e4
commit 089b3e7d66
6 changed files with 11 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
doc/man/taskrc.5.in
View file

@ -347,9 +347,9 @@ names you have used, or just the ones used in active tasks. The default value i
"no". "no".
.TP .TP
.B print.empty.columns=yes .B print.empty.columns=no
May be yes or no, and determines whether columns with no data for any task are May be yes or no, and determines whether columns with no data for any task are
printed. Defaults to yes. printed. Defaults to no.
.TP .TP
.B search.case.sensitive=yes .B search.case.sensitive=yes

2
src/Config.cpp
View file

@ -289,7 +289,7 @@ std::string Config::_defaults =
"complete.all.tags=no # Include old tag names in '_ags' command\n" "complete.all.tags=no # Include old tag names in '_ags' command\n"
"list.all.projects=no # Include old project names in 'projects' command\n" "list.all.projects=no # Include old project names in 'projects' command\n"
"list.all.tags=no # Include old tag names in 'tags' command\n" "list.all.tags=no # Include old tag names in 'tags' command\n"
"print.empty.columns=yes # Print columns which have no data for any task\n" "print.empty.columns=no # Print columns which have no data for any task\n"
"debug=no # Display diagnostics\n" "debug=no # Display diagnostics\n"
"extensions=off # Extension system master switch\n" "extensions=off # Extension system master switch\n"
"fontunderline=yes # Uses underlines rather than -------\n" "fontunderline=yes # Uses underlines rather than -------\n"

1
test/bug.455.t
View file

@ -34,6 +34,7 @@ use Test::More tests => 4;
if (open my $fh, '>', '455.rc') if (open my $fh, '>', '455.rc')
{ {
print $fh "data.location=.\n"; print $fh "data.location=.\n";
print $fh "print.empty.columns=yes\n";
close $fh; close $fh;
ok (-r '455.rc', 'Created 455.rc'); ok (-r '455.rc', 'Created 455.rc');

1
test/bug.804.t
View file

@ -36,6 +36,7 @@ if (open my $fh, '>', 'bug.rc')
print $fh "data.location=.\n"; print $fh "data.location=.\n";
print $fh "bulk=100\n"; print $fh "bulk=100\n";
print $fh "confirmation=no\n"; print $fh "confirmation=no\n";
print $fh "print.empty.columns=yes\n";
close $fh; close $fh;
ok (-r 'bug.rc', 'Created bug.rc'); ok (-r 'bug.rc', 'Created bug.rc');
} }

10
test/feature.print.empty.columns.t
View file

@ -44,16 +44,16 @@ qx{../src/task rc:bug.rc add sample desc 2>&1};
qx{../src/task rc:bug.rc add withP project:house 2>&1}; qx{../src/task rc:bug.rc add withP project:house 2>&1};
my $output = qx{../src/task test sample rc:bug.rc 2>&1}; my $output = qx{../src/task test sample rc:bug.rc 2>&1};
like ($output, qr/Project/, 'empty \'project\' column is printed by default'); unlike ($output, qr/Project/, 'empty \'project\' column is not printed by default');
$output = qx{../src/task test sample rc.print.empty.columns:no rc:bug.rc 2>&1}; $output = qx{../src/task test sample rc.print.empty.columns:yes rc:bug.rc 2>&1};
unlike ($output, qr/Project/, 'empty \'project\' column is not printed if rc.print.empty.columns:no'); like ($output, qr/Project/, 'empty \'project\' column is printed if rc.print.empty.columns:yes');
$output = qx{../src/task test rc:bug.rc 2>&1}; $output = qx{../src/task test rc:bug.rc 2>&1};
like ($output, qr/Project/, 'non-empty \'project\' column is printed by default'); like ($output, qr/Project/, 'non-empty \'project\' column is printed by default');
$output = qx{../src/task test rc.print.empty.columns:no rc:bug.rc 2>&1}; $output = qx{../src/task test rc.print.empty.columns:yes rc:bug.rc 2>&1};
like ($output, qr/Project/, 'non-empty \'project\' column is printed if rc.print.empty.columns:no'); like ($output, qr/Project/, 'non-empty \'project\' column is printed if rc.print.empty.columns:yes');
# Cleanup. # Cleanup.
unlink qw(pending.data completed.data undo.data backlog.data synch.key bug.rc); unlink qw(pending.data completed.data undo.data backlog.data synch.key bug.rc);

1
test/verbose.t
View file

@ -35,6 +35,7 @@ if (open my $fh, '>', 'verbose.rc')
{ {
print $fh "data.location=.\n", print $fh "data.location=.\n",
"echo.command=off\n"; "echo.command=off\n";
print $fh "print.empty.columns=yes\n";
close $fh; close $fh;
ok (-r 'verbose.rc', 'Created verbose.rc'); ok (-r 'verbose.rc', 'Created verbose.rc');
} }