GothenburgBitFactory/taskwarrior
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskwarrior.git synced 2025-08-20 04:13:07 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Remove unnecessary TDB2::{modify,add} argument

Browse source
This commit is contained in:
Dustin J. Mitchell 2023-04-30 21:46:01 +00:00 • committed by Dustin J. Mitchell
parent 5bb9857984
commit 0882a08d18
2 changed files with 6 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/TDB2.cpp
View file

@ -60,12 +60,11 @@ void TDB2::open_replica (const std::string& location, bool create_if_missing)
//////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////
// Add the new task to the replica. // Add the new task to the replica.
void TDB2::add (Task& task, bool/* = true */) void TDB2::add (Task& task)
{ {
// Ensure the task is consistent, and provide defaults if necessary. // Ensure the task is consistent, and provide defaults if necessary.
// bool argument to validate() is "applyDefault". Pass add_to_backlog through // bool argument to validate() is "applyDefault", to apply default values for
// in order to not apply defaults to synchronized tasks. // properties not otherwise given.
// This also ensures that the `uuid` attribute is set.
task.validate (true); task.validate (true);
std::string uuid = task.get ("uuid"); std::string uuid = task.get ("uuid");
@ -123,7 +122,7 @@ void TDB2::add (Task& task, bool/* = true */)
// This exhibits a bit of a race condition: if the stored task has changed since // This exhibits a bit of a race condition: if the stored task has changed since
// it was loaded, this will revert those changes. In practice, this is not an // it was loaded, this will revert those changes. In practice, this is not an
// issue. // issue.
void TDB2::modify (Task& task, bool/* = true */) void TDB2::modify (Task& task)
{ {
task.validate (false); task.validate (false);
auto uuid = task.get ("uuid"); auto uuid = task.get ("uuid");

4
src/TDB2.h
View file

@ -47,8 +47,8 @@ public:
TDB2 (); TDB2 ();
void open_replica (const std::string&, bool create_if_missing); void open_replica (const std::string&, bool create_if_missing);
void add (Task&, bool add_to_backlog = true); void add (Task&);
void modify (Task&, bool add_to_backlog = true); void modify (Task&);
void commit (); void commit ();
void get_changes (std::vector <Task>&); void get_changes (std::vector <Task>&);
void revert (); void revert ();