From 6bc537b9d95a8ab1547a747248103679ae4f8f90 Mon Sep 17 00:00:00 2001 From: Kyle Marek-Spartz Date: Tue, 10 Oct 2017 14:50:05 -0500 Subject: [PATCH 1/5] Hide information by default in review Originally submitted to taskwarrior-dev: https://groups.google.com/forum/#!topic/taskwarrior-dev/a8XizQmscl8 --- src/review.cpp | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/review.cpp b/src/review.cpp index 86ca12f..000838d 100644 --- a/src/review.cpp +++ b/src/review.cpp @@ -181,7 +181,7 @@ static const std::string banner ( //////////////////////////////////////////////////////////////////////////////// static const std::string menu () { - return Color ("color15 on gray6").colorize (" (Enter) Mark as reviewed, (s)kip, (e)dit, (m)odify, (c)omplete, (d)elete, (q)uit ") + " "; + return Color ("color15 on gray6").colorize (" (Enter) Mark as reviewed, (s)kip, (e)dit, (i)nformation, (m)odify, (c)omplete, (d)elete, (q)uit ") + " "; } //////////////////////////////////////////////////////////////////////////////// @@ -226,10 +226,6 @@ static void reviewLoop (const std::vector & uuids, unsigned int lim repeat = false; std::cout << banner (current + 1, total, width, Lexer::trimRight (description, "\n")); - // Use 'system' to run the command and show the output. - std::string command = "task " + uuid + " information"; - system (command.c_str ()); - // Display prompt, get input. response = getResponse (menu ()); @@ -241,6 +237,11 @@ static void reviewLoop (const std::vector & uuids, unsigned int lim else if (response == "") { reviewTask (uuid); ++current; ++reviewed; } else if (response == "r") { reviewTask (uuid); ++current; ++reviewed; } else if (response == "q") { break; } + else if (response == "i") { + // Use 'system' to run the command and show the output. + std::string command = "task " + uuid + " information"; + system (command.c_str ()); + } else { From 68d8a9acac5987a4bc27c37f630f663ed2b5f678 Mon Sep 17 00:00:00 2001 From: Paul Beckingham Date: Sat, 2 Jun 2018 19:57:55 -0400 Subject: [PATCH 2/5] Revert "Hide information by default in review" This reverts commit 6bc537b9d95a8ab1547a747248103679ae4f8f90. --- src/review.cpp | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/review.cpp b/src/review.cpp index 000838d..86ca12f 100644 --- a/src/review.cpp +++ b/src/review.cpp @@ -181,7 +181,7 @@ static const std::string banner ( //////////////////////////////////////////////////////////////////////////////// static const std::string menu () { - return Color ("color15 on gray6").colorize (" (Enter) Mark as reviewed, (s)kip, (e)dit, (i)nformation, (m)odify, (c)omplete, (d)elete, (q)uit ") + " "; + return Color ("color15 on gray6").colorize (" (Enter) Mark as reviewed, (s)kip, (e)dit, (m)odify, (c)omplete, (d)elete, (q)uit ") + " "; } //////////////////////////////////////////////////////////////////////////////// @@ -226,6 +226,10 @@ static void reviewLoop (const std::vector & uuids, unsigned int lim repeat = false; std::cout << banner (current + 1, total, width, Lexer::trimRight (description, "\n")); + // Use 'system' to run the command and show the output. + std::string command = "task " + uuid + " information"; + system (command.c_str ()); + // Display prompt, get input. response = getResponse (menu ()); @@ -237,11 +241,6 @@ static void reviewLoop (const std::vector & uuids, unsigned int lim else if (response == "") { reviewTask (uuid); ++current; ++reviewed; } else if (response == "r") { reviewTask (uuid); ++current; ++reviewed; } else if (response == "q") { break; } - else if (response == "i") { - // Use 'system' to run the command and show the output. - std::string command = "task " + uuid + " information"; - system (command.c_str ()); - } else { From 297b1b53c538b101c86cc9317a3190eaaa4168de Mon Sep 17 00:00:00 2001 From: David West Date: Sat, 8 Sep 2018 11:45:44 -0400 Subject: [PATCH 3/5] important info so people can build the project not obvious to use recursive without a tip --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index c484eed..db30b60 100644 --- a/README.md +++ b/README.md @@ -15,3 +15,6 @@ Thank you for taking a look at tasksh!! --- Tasksh is released under the MIT license. For details check the LICENSE file. + +# Important note +When cloning this from the repo to build from source make sure you `git clone --recursive` to get all required submodules. From abf75754f95cb5b8756e4ef898d4f8c4dd6a0a16 Mon Sep 17 00:00:00 2001 From: 0xACE <0xaced@gmail.com> Date: Sat, 12 Oct 2019 01:26:54 +0200 Subject: [PATCH 4/5] updated url for libshared submodule --- .gitmodules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitmodules b/.gitmodules index 675b3d4..0549462 100644 --- a/.gitmodules +++ b/.gitmodules @@ -1,3 +1,3 @@ [submodule "src/libshared"] path = src/libshared - url = https://git.tasktools.org/TM/libshared.git + url = https://github.com/GothenburgBitFactory/libshared From 27bdb5019db4964173f0ce47483528a1b3c81b02 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=20D=C3=B6rr?= Date: Sun, 9 Feb 2020 23:08:16 +0100 Subject: [PATCH 5/5] Add Installation Instructions for Debian/Ubuntu I spent quite some time trying to compile taskshell from source since I could not find `taskshell` with apt. Adding Installation Instructions might save other people time. --- README.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/README.md b/README.md index db30b60..b744a5f 100644 --- a/README.md +++ b/README.md @@ -1,3 +1,9 @@ +# Installing +* Debian/Ubuntu: +``` +$ sudo apt-get install tasksh +``` + # Disclaimer during ongoing development The development branch is a work in progress and may not pass all quality tests,