GothenburgBitFactory/taskshell
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/taskshell.git synced 2025-06-26 10:54:29 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

[TS-30] Let review use a filter

Browse source 
* This commit enables the review command of taskshell to use a custom
  filter, given from commandline.
* Unfortunately this kills the limit argument of the review command.
  This should be fixed!
This commit is contained in:
Sebastian Oeste 2018-04-03 18:22:34 +02:00
parent a2dc796574
commit 96f2c20598
1 changed files with 58 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

77
src/review.cpp
View file

@ -32,6 +32,8 @@
#include <algorithm>
#include <stdlib.h>
#include <iterator>
#ifdef HAVE_READLINE
#include <readline/readline.h>
#include <readline/history.h>
@ -266,16 +268,12 @@ static void reviewLoop (const std::vector <std::string>& uuids, unsigned int lim
}
////////////////////////////////////////////////////////////////////////////////
int cmdReview (const std::vector <std::string>& args, bool autoClear)
static void configureReport()
{
// Is there a specified limit?
unsigned int limit = 0;
if (args.size () == 2)
limit = strtol (args[1].c_str (), NULL, 10);
// Configure 'reviewed' UDA, but only if necessary.
std::string input;
std::string output;
auto status = execute ("task", {"_get", "rc.uda.reviewed.type"}, input, output);
if (status || output != "date\n")
{
@ -300,21 +298,62 @@ int cmdReview (const std::vector <std::string>& args, bool autoClear)
"( reviewed.none: or reviewed.before:now-6days ) and ( +PENDING or +WAITING )" }, input, output);
}
}
}
// Obtain a list of UUIDs to review.
status = execute ("task",
{
"rc.color=off",
"rc.detection=off",
"rc._forcecolor=off",
"rc.verbose=nothing",
"_reviewed"
},
input, output);
////////////////////////////////////////////////////////////////////////////////
int cmdReview (const std::vector <std::string>& args, bool autoClear)
{
// Is there a specified limit?
//unsigned int limit = 0;
unsigned int limit = std::numeric_limits<unsigned int>::max();
int status = 0;
bool with_filter = false;
std::string input;
std::string output;
std::vector<std::string> filter; // here we store our filter arguments
//if (args.size () == 2)
//limit = strtol (args[1].c_str (), NULL, 10);
if (args.size () > 1)
{
with_filter = true;
auto begin = args.begin();
std::advance(begin, 1);
std::copy(begin, args.end(), std::back_inserter(filter));
//TODO: maybe also add "status:pending" ?
filter.push_back("uuids");
}
configureReport ();
if (with_filter)
{
// Obtain list of UUIDs to review, when a filter is given
status = execute ("task",
filter,
input, output);
// Review the set of UUIDs.
auto uuids = split (Lexer::trimRight (output, "\n"), ' ');
reviewLoop (uuids, limit, autoClear);
}
else
{
// Obtain a list of UUIDs to review.
status = execute ("task",
{
"rc.color=off",
"rc.detection=off",
"rc._forcecolor=off",
"rc.verbose=nothing",
"_reviewed"
},
input, output);
// Review the set of UUIDs.
auto uuids = split (Lexer::trimRight (output, "\n"), '\n');
reviewLoop (uuids, limit, autoClear);
}
// Review the set of UUIDs.
auto uuids = split (Lexer::trimRight (output, "\n"), '\n');
reviewLoop (uuids, limit, autoClear);
return 0;
}