GothenburgBitFactory/task-timewarrior-hook
1
0
Fork 0
mirror of https://github.com/GothenburgBitFactory/task-timewarrior-hook.git synced 2025-09-05 23:17:21 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

on-modify.timewarrior: Deal with non-UTF-8 characters in input data from taskwarrior

Browse source 
When input data from taskwarrior (e.g. via bugwarrior) contains UTF-8-illegal characters, `on-modify.timewarrior` would fail:
```
Traceback (most recent call last):
  File "$HOME/.task/hooks/on-modify.timewarrior", line 42, in <module>
    old = json.loads(sys.stdin.readline())
  File "/usr/lib/python3.6/codecs.py", line 321, in decode
    (result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xed in position 1042: invalid continuation byte
```

This is fixed by manually decoding from stdin's underlying binary I/O object and replacing encoding errors with the Unicode replacement character [1].

[1]: https://docs.python.org/3/library/codecs.html#error-handlers
This commit is contained in:
Dennis Schridde 2019-07-11 19:18:32 +02:00 • committed by Thomas Lauf
parent 9f8a4c8161
commit 4af061abda
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
on-modify.timewarrior
View file

@ -39,8 +39,8 @@ import subprocess
# UDAs # UDAs
# Make no changes to the task, simply observe. # Make no changes to the task, simply observe.
old = json.loads(sys.stdin.readline()) old = json.loads(sys.stdin.buffer.readline().decode("utf-8", errors="replace"))
new = json.loads(sys.stdin.readline()) new = json.loads(sys.stdin.buffer.readline().decode("utf-8", errors="replace"))
print(json.dumps(new)) print(json.dumps(new))
def extract_timew_tags_from(json_obj): def extract_timew_tags_from(json_obj):